Implementation of a new EBL model from Finke et al. 2022. #465
Conversation
A new class -- inhereting from the TabularPhotonField class -- was created in the PhotonBackground.h file to fully implement the new EBL model. More over the model was added to various test calculations for every interaction in the testInteraction.cpp script.
|
For the record, I've been waiting for the changes in the CRPropa3-data repo to check and merge both together. |
|
Hi @rafaelab, @Yannick-Schmidt, @JulienDoerner |
| @@ -40,6 +40,8 @@ TEST(ElectronPairProduction, allBackgrounds) { | |||
| epp.setPhotonField(irb); | |||
| irb = new IRB_Stecker16_lower(); | |||
| epp.setPhotonField(irb); | |||
| irb = new IRB_Finke22(); | |||
There was a problem hiding this comment.
I am not creating a new commit just to fix the whitepace, but we should probably do this at some point in a consistent way for all files.
| @@ -718,6 +724,8 @@ TEST(EMPairProduction, allBackgrounds) { | |||
| em.setPhotonField(ebl); | |||
| ebl = new IRB_Stecker16_lower(); | |||
| em.setPhotonField(ebl); | |||
| ebl = new IRB_Finke22(); | |||
There was a problem hiding this comment.
Why is it called EBL here and IRB else?
There was a problem hiding this comment.
I think that depends on who implemented the test in the first place. Could be cleaned up in the future.
This PR adds the recent model from Finke et al. 2022 to the existing selection of custom photon fields. It is related to the corresponding pull request in the CRPropa-data repository.
The implementation includes the ...
TabularPhotonFieldbase class (in thePhotonBackground.hfile).testInteraction.cpp).